-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for loading in link trees depending on subdomain #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Got some nitpicks though
Co-authored-by: Mathias Magnusson <[email protected]>
Co-authored-by: Mathias Magnusson <[email protected]>
Next step is making the other text on the page customizable so you don't have to review until then. |
I believe the current status of this is that Dr. Ek finally found some common since and decided that this system is not needed. |
No way, how could Olof betray me like this 😭 |
Had a thought: wouldn't it be cleaner to have an env-var determine the content rather than the subdomain? Or was the plan to only have a single instance of the service running with multiple DNS-records pointing to it? |
description: Se dagordningen och bilagorna för mötet | ||
url: https://dsekt.se/handlingar | ||
icon: https://dsekt-assets.s3.amazonaws.com/namnder/systemgruppen/sm/handlingar.png | ||
color: "#ab000d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still think this should be at most a separate html site, but a pdf would also work :)
So, load different html files that already have the title and the other html in it, instead of in the yaml file? |
no |
Explain, or merge |
want links relevant for an sm? make a pdf |
This looks a whole lot nicer than a pdf opening in Google Drive. Drop the crack 🚭 |
I'd never support hosting files on google drive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would have something more dynamic allowing people to create and manage link trees with whatever they want for different purposes, but for now I think hardcoding it like this is fine.
I agree that this is better than a PDF and IMO it's probably ok, but maybe @foodelevator can sway my opinion if he has arguments against this. We can discuss tomorrow
Co-authored-by: Rafael Oliveira <[email protected]>
Co-authored-by: Rafael Oliveira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ser bra ut!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All that's left is now documenting how to go to the different link pages e.g. (http://sm.localhost:3000/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already changing my review but it's missing docs per Mathias's comment
@Benjaneb stop the steal! (Harmony is the "steal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muchos guchos
skvårsa och mördja |
Aaallt is now a link tree generator.