Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for loading in link trees depending on subdomain #7

Merged
merged 19 commits into from
Nov 28, 2024

Conversation

Benjaneb
Copy link
Contributor

Aaallt is now a link tree generator.

Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Got some nitpicks though

links/sm.json Outdated Show resolved Hide resolved
links/systems.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
@Benjaneb
Copy link
Contributor Author

Next step is making the other text on the page customizable so you don't have to review until then.

@foodelevator
Copy link
Member

I believe the current status of this is that Dr. Ek finally found some common since and decided that this system is not needed.

@Benjaneb
Copy link
Contributor Author

No way, how could Olof betray me like this 😭

@Benjaneb Benjaneb marked this pull request as ready for review November 21, 2024 21:28
@Herkarl
Copy link
Member

Herkarl commented Nov 22, 2024

Had a thought: wouldn't it be cleaner to have an env-var determine the content rather than the subdomain? Or was the plan to only have a single instance of the service running with multiple DNS-records pointing to it?

description: Se dagordningen och bilagorna för mötet
url: https://dsekt.se/handlingar
icon: https://dsekt-assets.s3.amazonaws.com/namnder/systemgruppen/sm/handlingar.png
color: "#ab000d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg

Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still think this should be at most a separate html site, but a pdf would also work :)

go.mod Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@Benjaneb
Copy link
Contributor Author

i still think this should be at most a separate html site, but a pdf would also work :)

So, load different html files that already have the title and the other html in it, instead of in the yaml file?

@foodelevator
Copy link
Member

foodelevator commented Nov 23, 2024

no

@Benjaneb
Copy link
Contributor Author

Explain, or merge

@foodelevator
Copy link
Member

want links relevant for an sm? make a pdf

@Benjaneb
Copy link
Contributor Author

This looks a whole lot nicer than a pdf opening in Google Drive. Drop the crack 🚭

@foodelevator
Copy link
Member

I'd never support hosting files on google drive

Copy link
Member

@RafDevX RafDevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would have something more dynamic allowing people to create and manage link trees with whatever they want for different purposes, but for now I think hardcoding it like this is fine.

I agree that this is better than a PDF and IMO it's probably ok, but maybe @foodelevator can sway my opinion if he has arguments against this. We can discuss tomorrow

links/systems.yml Outdated Show resolved Hide resolved
links/sm.yml Show resolved Hide resolved
main.go Show resolved Hide resolved
Benjaneb and others added 2 commits November 27, 2024 17:37
Co-authored-by: Rafael Oliveira <[email protected]>
Co-authored-by: Rafael Oliveira <[email protected]>
static/index.css Outdated Show resolved Hide resolved
Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut!

Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that's left is now documenting how to go to the different link pages e.g. (http://sm.localhost:3000/)

Copy link
Member

@RafDevX RafDevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already changing my review but it's missing docs per Mathias's comment

@foodelevator
Copy link
Member

@Benjaneb stop the steal!

(Harmony is the "steal")

Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchos guchos

@Benjaneb
Copy link
Contributor Author

skvårsa och mördja

@Benjaneb Benjaneb merged commit 277ccff into main Nov 28, 2024
@Benjaneb Benjaneb deleted the sm-links branch November 28, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants